Fix incorrect typings for Server class #152
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping? |
| on(event: 'headers', cb: (this: WebSocket.Server, headers: string[], request: http.IncomingMessage) => void): this; | ||
| on(event: 'listening', cb: (this: WebSocket.Server) => void): this; | ||
| on(event: 'stream', cb: (this: WebSocket.Server, stream: WebSocketDuplex, request: http.IncomingMessage) => void): this; | ||
| on(event: string | symbol, listener: (this: WebSocket.Server, ...args: any[]) => void): this; | ||
| } | ||
|
|
||
| function createServer(opts?: WebSocket.ServerOptions, callback?: () => void): Server; |
There was a problem hiding this comment.
Suggested change
| function createServer(opts?: WebSocket.ServerOptions, callback?: () => void): Server; | |
| function createServer(opts?: WebSocket.ServerOptions, callback?: (...args: any[]) => void): Server; |
I don't mind raising this as a separate PR, but this callback can take parameters,
if you look whats passed into the callback you can see that this is passed into this.on('stream', cb) in server.js
which is a method on its super class WebSocketServer which is part of the ws package
In there they have many different callback types
There was a problem hiding this comment.
my brother in christ, this has been open for 4 years now
There was a problem hiding this comment.
Ah actually there is another ticket raised about this here #158 - don't worry
max-carroll-sky
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.